Closed gogainda closed 2 years ago
Side observation, unrelated to the PR. Wondering why GitHub check for ruby-head
is red, while we have continue-on-error: ${{ matrix.allow_failure || endsWith(matrix.ruby, 'head') }}
. It was usually swallowing all errors and (deceptively) showing as green.
PS probably GH changed that to be less deceptive and avoid confusion between ignored failures and legitimately green builds.
PS probably GH changed that to be less deceptive and avoid confusion between ignored failures and legitimately green builds.
Would be great if they fixed something there, people have been complaining about allow-failure support for more than a year (me included).
Can you rebase this again, github appears to be MIA
@JonRowe PR is ready, could you review it one more time?
@eregon should I convert the failing spec to an issue?
@gogainda Could you mention it on the rspec-metagem issue for TruffleRuby support, and I or bjfish will take a look?
@eregon one failure left