Add #fits and #xits methods

[bazay]

RSpec core library has a convention of prepending 'f' and 'x' to it's methods to support running certain blocks or tests with :focus or :skip tags. This commit aims to bring rspec-its inline with this convention by making #fits and #xits methods available to the spec writer.

[bazay]

I'm also happy to update README with both methods with the commit resolving this discussion: https://github.com/rspec/rspec-its/pull/79#discussion_r527912231

[JonRowe]

Thanks for the suggestion, I'm not totally convinced I want to expand this library, it exists for legacy reasons (it was extracted from rspec) and we don't encourage it's use.

[bazay]

I know a lot of teams who still use this gem in everyday use so it still has value beyond usage in legacy apps. Ultimately I think it should be up to the individual developer to decide or at least be given the choice :)

Perhaps a solution would be to allow new contributions to be added on a new major release version (e.g. v2.0.0) to clearly extend on the original "supporting for legacy reasons" purpose of this gem.

[JonRowe]

I know a lot of teams who still use this gem in everyday use so it still has value beyond usage in legacy apps. Ultimately I think it should be up to the individual developer to decide or at least be given the choice :)

Indeed it is, which is why the gem even exists, but thats different from wether the RSpec team want to accept new features which creates additional maintenance burden for us.

[bazay]

Looks like something unusual happened whilst running the test-suite. Perhaps Travis needs to be kicked 👢

[pirj]

Perhaps Travis

We're moving other repos to GHA. Not focused on rspec-its/rspec-collection-matchers, you can lend a hand if you like.

[bazay]

Sure I can take a look

[bazay]

I've added GHA here: https://github.com/rspec/rspec-its/pull/80

[bazay]

Hey @JonRowe thanks for merging in your GHA changes. Looks like Travis is having some trouble installing bundler, though not sure why as gem install bundler -v '< 2' isn't specified in the .travis.yml from what I can tell 🤔

[bazay]

Hey @JonRowe @pirj any update on this - is there anything you want me to do on my end? :)

[bazay]

ping @JonRowe 😬

[JonRowe]

Thanks for the suggestion, I'm not totally convinced I want to expand this library, it exists for legacy reasons (it was extracted from rspec) and we don't encourage it's use.

ping @JonRowe 😬

My original reticence remains, I don't have time to maintain this gem and release new features for it, so this is far down on my to do list.