Test against Class#new and not Class.new for the "is it #new from Class" check - Githubissues

rspec / rspec-mocks

RSpec's 'test double' framework, with support for stubbing and mocking

https://rspec.info

MIT License

1.16k stars 358 forks source link

Test against Class#new and not Class.new for the "is it #new from Class" check #1476

Closed eregon closed 2 years ago

eregon commented 2 years ago

On CRuby this makes currently no difference (there is no Class.new, only Class#new), but on TruffleRuby there is both (in order for Class objects to be fully initialized on creation, https://github.com/oracle/truffleruby/commit/8e8c501b3df2f54022be6f09304fd907e59a68ed).

Improves over https://github.com/rspec/rspec-mocks/pull/1470.

This helps for TruffleRuby support (https://github.com/rspec/rspec-metagem/issues/68). Specifically it fixes this error: https://github.com/bjfish/rspec-core/runs/6857305517?check_suite_focus=true