Closed honigc closed 1 year ago
@JonRowe Done
Updated again to use eval
to set up the kwarg method in tests, to avoid syntax errors in old Rubies
Hi @JonRowe! We're eager to see this merged—anything I can do to help move it forward?
Can this get rebased? That might trigger the build again
Yesterday I rebased, added a separate changelog commit and force-pushed, no build :thinking: On the Actions tab, it says "Workflow runs completed with no jobs".
Theres no changelog or seperate commit here, so no build... You must have pushed it to a different branch?
ERROR: Permission to panorama-ed/rspec-mocks.git denied to pirj
Might be "allow edits for maintainers" is turned off for this PR?
@honigc Do you mind ticking that checkbox please, or rebase and push again for the build to trigger?
Thanks for the work on this @honigc sorry it took so long to merge.
The current re-implementation of
send
on verifying doubles uses*args
by itself. Everything works fine onmain
for Ruby 2 or lower, but on Ruby 3 this converts keyword arguments to a Hash element inside theargs
array, which then gets passed to__send__
and thensuper
and (correctly) causes a failure when the method gets a Hash instead of keywords.Without this patch, the new test passes on Ruby 2.7.6 and fails on Ruby 3.1.2:
With this patch, all tests pass on all Ruby versions.