Closed threeplanetssoftware closed 10 months ago
Please see the latest push for fixes to the above issues. Will go back and check the other repos I touched.
My apologies for not noticing the ordered list repeating number 1. I have fixed the indentation of those blocks so that the list is ordered again. I ran the cucumber checks again and it is still passing. Have a great evening,
check all these fence changes against the website generation
Two observations:
I will take a closer look later.
Thank you!
These have been published, they don't change the output though because our syntax highlighting on features at least don't support the extra information I guess
Good morning! I appreciate your pushing a fresh copy of the docs live, I know that can be tedious.
I believe the updated formatting should work, as I was able to use your rspec-dev
and rspec.github.io
repositories to view it. I suspect the issue is that the latest rspec-rails
tag (6.1.1) was cut two weeks ago, prior to merging these documentation changes.
I can recreate the formatting issue on the current rspec-dev
repository by running rake update-docs["6.1.1"]
. If I add a new tag to rspec-rails
of 6.1.2 at the current head, then update_docs
displays the newer formatting.
Note: I do not expect you to cut a new release just for documentation, but whenever you do have a new release, I believe this will work. Thank you again for your work on rspec, I have been adding a lot of it in the past week and have greatly enjoyed it.
The build ran against 6-1-maintenance which is supposed to pull in changes even if not released, I also noticed no change locally on my machine 🤔
Similar to the PRs to
rspec-expectations
andrspec-core
, this PR just updates the documentation to better provide syntax highlighting for code blocks. Two things I didn't touch which you might want to consider your stance on in the future:As before, I ran the automated tests and Cucumber didn't report any issues: