search

rspec / rspec-rails

RSpec for Rails 6+
https://rspec.info
MIT License
5.16k stars 1.03k forks source link

fix: link at mailer preview generator template #2764

Closed chiaraani closed 3 months ago

chiaraani commented 3 months ago

When I execute:

rails g mailer users/confirmations

The link to the preview at the comment is this:

http://localhost:3000/rails/mailers/users/confirmations

This route raises this error:

Unknown action
Mailer preview 'users/confirmations' not found

So I fixed it.

pirj commented 3 months ago

Do you think it’s possible to write a failing spec for this?

JonRowe commented 3 months ago

Thanks, merging despite build failure as its just a template typo

chiaraani commented 3 months ago

Is it necessary to add a test for a generated code comment?

JonRowe commented 3 months ago

Personally I don't think so, it would be hard to do in a way that wasn't brittle.

JonRowe commented 3 months ago

Released in 6.1.3