Open smathieu opened 2 weeks ago
I agree with you.
FYI: My workaround is allow_any_instance_of(RSpec::Rails::Matchers::ActiveJob::Base).to receive(:detect_args_signature_mismatch).and_return(nil)
Sorry to hear the signature-match check is causing issues for you both – adding an escape hatch sounds reasonable.
FWIW one can also store arbitrary data on an ActiveJob job by overriding #serialize
and #deserialize
to store/retrieve an extra value on the job payload hash. This would allow you to avoid adding then deleting a job argument, and allow the signature-match check to pass.
So in the example above you'd override #serialize
to store the actor, #deserialize
to populate an @actor
instance variable, which can then be referenced in your around_perform
hook...
Overriding #serialize
is a much cleaner implementation and we'll switch over to that.
Given this is an edge cases and there are documented workaround in this ticket, I think we can close this.
Is your feature request related to a problem? Please describe.
The 7.0 version of RSpec Rails introduced https://github.com/rspec/rspec-rails/pull/2745 by @odlp which is overall a great addition, but doesn't provide a configuration to disable this check.
This is a problem for one of our app that uses
before_enqueue
andaround_perform
callbacks that modifies the arguments passed to the job.Describe the solution you'd like
I would like a way to disable this check.
Describe alternatives you've considered
I'm not sure there are other solutions short of updating all the jobs in our app.
Additional context
Here are the callbacks being used: