search

rspec / rspec-support

Common code needed by the other RSpec gems. Not intended for direct use.
https://rspec.info
MIT License
98 stars 103 forks source link

`diff-lcs` has changed its format in 1.4 #421

Closed JonRowe closed 4 years ago

JonRowe commented 4 years ago

The recent diff-lcs update changed some parts of the diff output, breaking our builds, these seem trivial enough to ignore (e.g. they don't seem wrong, just different).

Draft because I'm going to improve the formatting of this spec a bit whilst I'm here, and I'm going to setup CI to test both versions of diff-lcs.

JonRowe commented 4 years ago

Related I've asked the diff-lcs team to bump their major version if they make Ruby changes in halostatue/diff-lcs#62 they have dropped "soft" support for older rubies, which in turn means 1.4 is broken on our older Rubies.

halostatue commented 4 years ago

Can you detail the changes that were breaking for you on this with examples as a bug against diff-lcs? As I mentioned in halostatue/diff-lcs#62, I am willing to consider some changes to how diff-lcs works when running under RSpec so that we keep compatibility as much as possible.

JonRowe commented 4 years ago

@halostatue This PR contains examples of the changed output, the line number headers have changed in some cases, and some unchanged lines have been removed, I'm totally fine with working around that in the two versions like this PR does :)