Closed pirj closed 3 years ago
I have no idea what's up with Travis, the build shows as "queued", but I don't see any other builds running, including Core and Mocks' rc4.0
branches.
This is worrying:
Any PRs working up proposals for RSpec 4.0 need to be marked as draft as they will require very careful release management, they will not be merged to main for a long time.
I've created a 4-0-dev
branch on all the repos, please target any PRs to that branch
@JonRowe Sounds good, thanks!
May I kindly ask you to grant me rspec/rspec
repo branch push permission? I can push to any other repo's branch, but not rspec/rspec
.
Not being able to push a branch with matching name results in build errors:
Fetching https://github.com/rspec/rspec.git
fatal: Needed a single revision
Git error: command `git rev-parse --verify rc4.0` in directory
I'll close this PR and will open another one with a more descriptive branch name (drop-old-rubies
or alike).
@pirj just make sure to target 4-0-dev
, I'll get it setup properly at the weekend. RSpec 3.x will continue to support the current Ruby matrix
Superseded by #436
Better viewed ignoring indentation changes https://github.com/rspec/rspec-support/pull/435/files?diff=split&w=1
As per https://github.com/rspec/rspec/issues/61#issuecomment-687290045
Minimal changes to
rspec-core
andrspec-mocks
were required to runrspec-support
's own spec suite, pushed to branches with the same name.What has been done
Done:
Discuss:
TODO:
for rspec-dev: