Drop Ruby < 2.3 support

pirj commented 3 years ago

Better viewed ignoring indentation changes https://github.com/rspec/rspec-support/pull/436/files?diff=split&w=1

As per https://github.com/rspec/rspec/issues/61#issuecomment-687290045

Sibling PRs:

Minimal changes to rspec-core and rspec-mocks were required to run rspec-support's own spec suite, pushed to branches with the same name.

What has been done

Done:

[x] clean up RubyFeatures
[x] check respond_to?
[x] check method_defined?
[x] check send (where we call private methods that later became public)
[x] cleanup Gemfile
[x] update required_ruby_version
[x] update VERSION
[x] check RUBY_VERSION usages
[x] check if we require_rspec_support ruby_features where RubyFeatures are not used
[-] check define_method where def would suffice
[x] check (class << self; self; end) usages for possibility to use singleton_class (some can't be replaced as singleton_class does create a singleton class if it doesn't exist yet)
[x] check if Java::JavaLang::String.instance_method(:char_at).arity == -1
[?] check Java::JavaLang::String.instance_method(:char_at).parameters == [] - still the case
[x] check 1.8, 1.9, 2.0, 2.1, jruby, 9.0, 9.1, mri
[x] check requires for support's mutex
[x] check eval
[x] check "work around", "workaround" - there are two cases: check if this was fixed in JRuby 9.2
[x] check docs
[-] ~WithKeywordsWhenNeeded~ - will be addressed separately
[x] gsub/unindent where squiggly heredoc can be used
[-] ~remove ripper_supported?~ - it has poor support in JRuby 9.1

pirj commented 3 years ago

For some reason, builds stopped triggering. Going to switch to "ready for review" temporarily just to figure out if it's the case (quite unlikely though).

benoittgt commented 3 years ago

For the build issue it is because of travisci config. https://github.com/rspec/rspec-support/pull/436/commits/112973040cbab3bfb69b23bc21b03bc084c93e00

pirj commented 3 years ago

@JonRowe Thanks for the review.

I've outlined the things to discuss in the description, including:

[?] extract rubocop changes into a separate pull request

I'll extract this into a separate follow-up pull request to 4-0-dev.

pirj commented 3 years ago

@JonRowe @benoittgt Appreciate if you can take a look at Discuss section of the description, there are some important questions, let me cite below:

introduce https://github.com/ruby/ruby2_keywords dependency and remove respond_to?(:ruby2_keywords, true) check
cleanup of build functions/predicates - any objections? (for sure in a separately pull request, and coming from rspec-dev)
drop Ruby 2.3 - problematic'ish due to a dependency on outdated OpenSSL, EOL'ed, not supported by RuboCop, still used by 8% of users
tweak clone_repo to accept a branch, use maintenance-branch's branch for main repos, and 4-0-maintenance for cloning rspec-rails since it's alienated anyway?

JonRowe commented 3 years ago

[?] introduce https://github.com/ruby/ruby2_keywords dependency and remove respond_to?(:ruby2_keywords, true) check

No, we can't introduce dependencies.

[?] drop Ruby 2.3 - problematic'ish due to a dependency on outdated OpenSSL, EOL'ed, not supported by RuboCop, still used by 8% of users

What Rubocop supports does not drive us. 2.3 is not really problematic.

[?] tweak clone_repo to accept a branch, use maintenance-branch's branch for main repos, and 4-0-maintenance for cloning rspec-rails since it's alienated anyway?

It already does this? Its just hardcoded based on the branch?

[?] extract rubocop changes into a separate pull request

Just remove them, they're unneeded.

pirj commented 3 years ago

and 4-0-maintenance for cloning rspec-rails since it's alienated anyway?

It already does this? Its just hardcoded based on the branch?

Doesn't seem to. The build was failing without drop-old-rubies rspec-rails branch. Also, it failed with default version.rb:

Resolving dependencies...

Bundler could not find compatible versions for gem "rspec-core":

  In Gemfile:
    rspec-core
    rspec-rails was resolved to 4.1.0.pre, which depends on
      rspec-core (= 3.11.0.pre)

Changed it to 4.0.0.pre to trick this build.

pirj commented 3 years ago

I'm getting stuck with removing WithKeywordsWhenNeeded and dealing with kwargs delegation related failures in combination with dropping support for old rubies. Removal of WithKeywordsWhenNeeded is tangential to the removal of rubies, and I'm going to remove all eval hacks, but not kwargs delegation hacks. I intend to address the removal of WithKeywordsWhenNeeded and kwargs delegation issues and hacks in a separate series of pull requests.

pirj commented 3 years ago

@JonRowe I intend to add back a jruby-9.1 build job, ~and make an attempt to remove ripper_supported? after that~.

pirj commented 3 years ago

No CI-related files included in this change! Suddenly all-green CI 🎉

@benoittgt @JonRowe welcome for a review.

PS and huge thanks for your work on JRuby/Windows/CI etc, guys. Your work has made this cleanup possible ❤️

pirj commented 3 years ago

Updates:

reverted jruby_version removal and its usages
pinned ffi at ~> 1.12.0
accepted Changelog proposed change (breaking change section)
reverted error filtering changes in stderr_splitter

pirj commented 3 years ago

Update: combined ReentrantMutex with Mutex.

pirj commented 3 years ago

Update: reset the temporary maintenance-branch commit.

Green! 💚

pirj commented 3 years ago

🎉

rspec / rspec-support

Drop Ruby < 2.3 support #436

What has been done