search

rspec / rspec-support

Common code needed by the other RSpec gems. Not intended for direct use.
https://rspec.info
MIT License
98 stars 103 forks source link

Updates from rspec-dev (2020-11-16) #437

Closed JonRowe closed 3 years ago

JonRowe commented 3 years ago

These are some updates, generated from rspec-dev's rake tasks.

JonRowe commented 3 years ago

Is it possible to only run one build? Either for the branch (main, -maintenance, -dev) or for the PR?

Don't know, my standard knowledge says that you need pr so that, er pull requests are built, but you also need push so that branches pushed up by us run.

JonRowe commented 3 years ago

We might be able to limit push to main and maintenance branches?

JonRowe commented 3 years ago

This sometimes happens with Travis as well by the way, it's just we don't see it

pirj commented 3 years ago

This sometimes happens with Travis as well by the way, it's just we don't see it

We found a reason for that with Benoit, it's that removed branches setting for rspec-rails. Doesn't happen with other repos.

JonRowe commented 3 years ago

We found a reason for that with Benoit, it's that removed branches setting for rspec-rails. Doesn't happen with other repos.

That branches option was deliberately limiting builds on rspec-rails becauase of the load it causes.

pirj commented 3 years ago

That branches option was deliberately limiting builds on rspec-rails

branches option is not only in rspec-rails:

branches:
  only:
    - main
    - /^\d+-\d+-maintenance$/

Frankly, we have everywhere except rspec-rails, resulting in exactly the opposite effect :laughing: