search

rspec / rspec-support

Common code needed by the other RSpec gems. Not intended for direct use.
https://rspec.info
MIT License
98 stars 103 forks source link

Updates from rspec-dev (2020-11-21) #440

Closed JonRowe closed 3 years ago

JonRowe commented 3 years ago

These are some updates, generated from rspec-dev's rake tasks.

pirj commented 3 years ago

Ripper is supported on 9.1.17.0 according to test suite

👍 Good to know. I indeed to remove one more method from RubyFeatures in drop-old-rubies.

JonRowe commented 3 years ago

ripper_supported? is not a method that should be removed.

pirj commented 3 years ago

@JonRowe, do you mind to elaborate why, to support JRuby 9.1?

JonRowe commented 3 years ago

Because we need it to flag ripper support on Rubies that don't. This includes JRuby 9.1 below 17, and Rubinius.

pirj commented 3 years ago

Right, Rubinius slipped my mind completely 👍 I had an impression that there's a jruby? check when defining ripper_supported? in drop-old-rubies, but .rbx? is the only one.