Closed JonRowe closed 3 years ago
It's beyond my understanding how this passes when .travis.yml
is removed, but this line is still in place:
bundle_install_flags=`cat .travis.yml | grep bundler_args | tr -d '"' | grep -o " .*"`
It's beyond my understanding how this passes when .travis.yml is removed, but this line is still in place:
bundle_install_flags=`cat .travis.yml | grep bundler_args | tr -d '"' | grep -o " .*"`
It's empty when it fails, and bundle has already happened in github actions, so it presumedly has the config from that cached. This can be cleaned up at a later (post 4.0.0 merge to master) date.
This can be cleaned up at a later (post 4.0.0 merge to master) date.
Or applied to both I guess, just it need not be a 4.0.0 specific change
It's empty when it fails
I guess we don't set set -e
, so this subshell call doesn't fail the caller if it fails itself, and we just go on.
👍
These are some updates, generated from rspec-dev's rake tasks.