search

rspec / rspec-support

Common code needed by the other RSpec gems. Not intended for direct use.
https://rspec.info
MIT License
95 stars 104 forks source link

Support TruffleRuby #533

Closed gogainda closed 2 years ago

pirj commented 2 years ago

Wouldn't it be more convenient for TruffleRuby to include RSpec into their build?

pirj commented 2 years ago

One reason for this is that we're really capped by the GHA tier, and with the number of Ruby versions we support getting a single build to run takes several minutes. For rspec-rails, it's even worse - it can be up to half an hour. If other builds in rspec organization are running, they are queuing up.

To ba fair, we're seizing support for older Ruby versions in RSpec 4, but there are still a plenty of versions to support, with Ruby 3.1 and ruby-head missing from that list.

We were thinking of removing JRuby builds and relying on JRuby to test Ruby compatibility on their side, but don't want to do this abruptly. If there's an incompatibility with TruffleRuby or JRuby, it's a burden for us to fix, and we hope for the cooperation of their core teams to help with the fixes.

Do you think it would be possible to add a job that runs RSpec tests along TruffleRuby builds instead of adding a TruffleRuby job that runs along with RSpec builds?

eregon commented 2 years ago

Thank you for merging this. I opened an issue to figure what would be needed to officially support TruffleRuby in RSpec: https://github.com/rspec/rspec-metagem/issues/68