search

rspec / rspec.tmbundle

Textmate bundle for RSpec.
MIT License
196 stars 52 forks source link

Ruby18 shim and Commands rework [WIP] #85

Closed elia closed 10 years ago

elia commented 10 years ago

continuing from https://github.com/rspec/rspec-tmbundle/pull/80#issuecomment-51308774

elia commented 10 years ago

@noniq what if we change all runners to always shell out instead of trying to reuse the command's ruby?

I saw that in case of bundler binstubs it already does that. Also that would open up for further .tm_properties/env customizations (e.g. TM_RSPEC_COMMAD could be used to make stuff work with rspec1).

noniq commented 10 years ago

Reworking the runners is a good idea. But let’s get the simple things done first! :-)

noniq commented 10 years ago

@elia Are these the right commits for this PR, or did something get mixed up? (Looks like these commits should belong to a PR called “fix switch command” or similiar :wink: )

elia commented 10 years ago

kinda, but truth is that all I wanted was an empty PR, which apparently is not allowed (anymore?)

elia commented 10 years ago

@noniq there we go, just the shim and the update of .tmCommand XML to TM2 format

now starting a commands rewrite branch ;)

noniq commented 10 years ago

Thanks!