search

rspeer / dominiate

A simulator for Dominion card game strategies
http://rspeer.github.com/dominiate
MIT License
121 stars 43 forks source link

I got a syntax error while compiling your code #55

Closed Narmical closed 12 years ago

Narmical commented 12 years ago

Dear rspeer,

I downloaded your dominion simulator code with hopes of creating a evolutionary algorithm to machine learn better dominion strategies. When i compiled basicAI.coffee I got a syntax error related to incorrect unindenting. I assume this discrepancy has something to do with platform differences (I'm on windows).

I checked in the change, if it still works ok for you, i think it will be helpful for others new to your code trying to compile on windows.

Thanks, Mitch Morris

rspeer commented 12 years ago

It seems that CoffeeScript has changed significantly under me. Thanks for taking the time to find the syntax changes I need to make.

But I'm afraid I can't accept this pull request, because it also includes a bunch of other changes, and some of them would break things that previously worked. Probably the right thing for me to do is to manually make the appropriate changes.

It's very encouraging that this almost runs in Node on Windows now. Now I don't have to recommend the horrible hack in the windows/ subdirectory. I bet with a bit more path wrangling you could make it run without having to change the "require" lines -- do you think you could do this?

Narmical commented 12 years ago

Sorry i totally missed your comments. I'm new to gitHub etc. etc.

Quick recap of what happened. I fixed the coffee script errors, check it in, initiated pull request. then checked in more changes that i was working on. Both got included in the pull request (didn't mean to not sure what I'm doing still)

I hope i helped, even if most of my stuff didn't work out so well.

Please let me know what i can do going forward to make things more compatable (ie the include dirs)