Updated setup.py - Githubissues

rspeer / wordfreq

Access a database of word frequencies, in various natural languages.

Other

1.4k stars 101 forks source link

Updated setup.py #53

Closed ixxie closed 6 years ago

ixxie commented 6 years ago

In the course of trying to package wordfreq for Nix I discovered your setup.py appears out of date; here are my proposed changes:

in dependencies, update: msgpack-python to msgpack
bumped version to 1.7.0,
made regex dependency more forgiving in version number, making the condition >= rather than ==.

For the last one, I am not sure, since I don't know if you had particular reasons for demanding a particular revision of regex.

ixxie commented 6 years ago

Ping @rspeer?

Tahnan commented 6 years ago

@ixxie - Rob's been out of town for a couple of days, but he'll be back tomorrow. We'll make sure this is on his radar when he gets back. :-)

rspeer commented 6 years ago

Is the regex requirement necessary to satisfy some constraint? We set a fixed version of it so that the behavior wouldn't change without warning - for example, due to changes to Unicode.

rspeer commented 6 years ago

I'm going to close this PR, but only to merge one very like it without the regex requirement change.

ixxie commented 6 years ago

Cheers @rspeer, I will ensure that is in my environment.