search

rspivak / slimit

SlimIt - a JavaScript minifier/parser in Python
MIT License
551 stars 94 forks source link

Using $ for mangled function names conflicts with jQuery #36

Closed rivol closed 11 years ago

rivol commented 12 years ago

I have a "class" function with many subfunctions inside of it. When compressing it with Slimit, the function name mangling uses $ and _ for function names which results in errors because I am using jQuery and expect $ to remain reserved for jQuery.

See the testcase at https://gist.github.com/3806569 Names of functions 52 and 53 are mangled to $ and _ which breaks jQuery usage.

$ and _ are both used by popular JS libraries (jQuery and Underscore.js) so I'd suggest not to use them for function names.

Removing those 2 chars from ID_CHARS in scope.py fixes the problem for me, but I don't know if it might have any side effects.

rspivak commented 12 years ago

Thanks for filing the issue. I'll look into it.

rspivak commented 11 years ago

Fixed in ada895eb1e06ddd1c0829bb1faf2bfc40da19119