rssh / scala-gopher

Implementation of CSP constructions (Communication Sequence Process, i.e. go-like channels) in scala
Apache License 2.0
199 stars 7 forks source link

assorted failures in Scala community builds #20

Closed SethTisue closed 6 years ago

SethTisue commented 7 years ago

seen at https://scala-ci.typesafe.com/job/scala-2.12.x-integrate-community-build/1389/consoleFull:

[scala-gopher] [info] AsyncSelectSuite:
[scala-gopher] [info] - async base: channel write, select read
[scala-gopher] [info] - async base: select write, select read
[scala-gopher] [info] - async base: select read, default action *** FAILED ***
[scala-gopher] [info]   consumer.isCompleted was false (AsyncSelectSuite.scala:106)
rssh commented 7 years ago

added extra consumer wait: https://github.com/rssh/scala-gopher/commit/f6b61fbc90176c079108057abb4db51e290b73d2 // look for next build.

SethTisue commented 7 years ago

more failures:

[scala-gopher] [info] *** 2 TESTS FAILED ***
[scala-gopher] [error] Failed tests:
[scala-gopher] [error]  gopher.channels.DuppedChannelsSuite
[scala-gopher] [error]  gopher.channels.FoldSelectSuite

from https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/325/consoleFull

SethTisue commented 7 years ago

and another one:

[scala-gopher] [info] *** 1 TEST FAILED ***
[scala-gopher] [error] Failed tests:
[scala-gopher] [error]  example.SieveSuite

from https://scala-ci.typesafe.com/job/scala-2.13.x-integrate-community-build/326/consoleFull

SethTisue commented 7 years ago

This seems to be a systemic problem, so I'm going to disable scala-gopher's test suite (we'll compile the tests, but not run them); we could undo that change if you become confident you have a systemic fix (perhaps you could run the tests on a slow and/or heavily loaded machine, to provoke similar failures)?

SethTisue commented 7 years ago

seen recently on 2.11 build:

[scala-gopher] [info] *** 6 TESTS FAILED ***
[scala-gopher] [error] Failed tests:
[scala-gopher] [error]  gopher.channels.MacroSelectSuite
[scala-gopher] [error]  gopher.transputers.TransputerRestartSuite
[scala-gopher] [error]  gopher.channels.IOTimeoutsSuite
[scala-gopher] [error]  gopher.transputers.ReplicateSuite

I'll disable running the tests in 2.11 as well (was already disabled for 2.12/2.13): https://github.com/scala/community-builds/pull/537

SethTisue commented 6 years ago

closing since it hasn't gotten any attention

rssh commented 6 years ago

btw, the problem is targeted in #21. Another thing, as in any OSS project, that it's hard to say something concrete when it will be delivered ;)