Closed rssidlowski closed 9 years ago
ready for testing as noted and pending Lu's work on the UI
Verified.
From COB personnel:
I had noticed that the SDUO report is not correct. Currently, when the SDUO report is generated; it includes all the PST investigations within the specified date range. It should only have SDUO information collected in the specified date range. Below is how the SDUO report should look.
See below:
Revised to two reports. This report becomes the 'investigations with Discharge Classification' and allows user to enter a date range and select any number of Discharge Classification values as defined on the Investigation record.
Here is a sample mockup of this report:
The second report is all investigations that have at least one sample with SDUO at the sample level. Only list the samples that are classified as SDUO. Allow user to enter date range.
Note that I had to do these in VS 2013 with all other reports in 2010, so they needed to be their own web app. Not ideal, but not a problem. The code is in the same place as the other reports in SVN.
The 2 SDUO reports are done same in dev as prod (so for the below, the only difference is “dev” vs. “view” in the URL)
For the 1st report -- Investigations with Discharge Classifications – you need have the UI send a URL with … SDUO/SDUO.aspx/ then the query string like below,
http://dpwview.baltimorecity.gov/SDUO/SDUO.aspx?reporttype=1&vals=1,2,3,4&d1=1/1/2009&d2=1/1/2014
Where the vals parameter is the DC_ID from the table below. So you would show the DC_DESC in the UI with the option to select multiple and make a CSV string for the query. (Do we really want to show “None” as an option?, I don’t see why we would)
gis_admin_PST_DISCHARGE_CLASSIFICATION DC_ID DC_CODE DC_DESC 0 None 1 SDUO SDUO 2 SSO SSO 3 SSOP SSO_Private 4 PW Potable Water
Then d1, d2 are the date-range (works also with leading zeros for the day/month)
The 2nd report -- Investigations with SDUO Samples -- just needs the reporttype and the date range: http://dpwview.baltimorecity.gov/SDUO/SDUO.aspx?reporttype=2&d1=1/1/2009&d2=1/1/2014
The nitrate+nitrate is missing the left parenthesis: This is in both SDUO reports.
fixed
Nitrate+Nitrate should be Nitrate+Nitrite.
Done
Verified in COB dev. Needs to be moved to production.
you should be seeing the same in prod, I made the same changes in both places.
I got further clarification on the Discharge Classification report from COB personnel. The TKN values are actually the "Kjeldahl Nitrogen (Total)" in the parameters for lab data and the Nitrate+Nitrite is associated to the "Nitrate+Nitrite-Nitrogen" in the parameters for lab data.
Yeah, that makes sense ... you should have known that :-) Changed in dev & prod, please do a spot check against original data if you can
I verified some samples. Looks good to me. Will have COB personnel verify.
Description: this report is a list of the investigations reported (created) in a specified date range which are SDUO. Inputs: User selects the from and to date to include. Sample output. Title at Top:
SANITARY DISCHARGE UNKNOWN ORIGIN (SDUO) From 01/01/2014 to 06/30/2014
Report is in Date order and includes the following Fields: Create Date Name Location Description Problem Type Watershed Stream Name Status
Include a total for the number of SDUO in the specified date range at the end of the report..