search

rssiweb / phoenix_backend

0 stars 1 forks source link

Add button to delete marks entered for a test #20

Closed sahasomnath closed 6 years ago

zkhan93 commented 6 years ago

there is a loading, icon visible as soon as marks are entered, in case of failure it will show a notification, with error, showing notification on every action will create a lot of notifications.

strongly related to #19 close this and dicuss on #19 to have discussion on same page

sahasomnath commented 6 years ago

Hey, this issue is related to reset button. it has nothing to do with auto save.

zkhan93 commented 6 years ago

As soon as user input some marks, it is getting save in backend, if you want a reset button to clear records on a page it will be deleting all the marks recorded for that test. Do you really want that ?

Also the reset button is for forms that are not submitted unless you press submit or save button, but here as soon as you make changes its saved, hence no reset, if you really need it, it should be called delete all

sahasomnath commented 6 years ago

Yes please. Delete all is the correct term. Thanks. Please don't forget to add notification pop-up on that particular button.

sahasomnath commented 6 years ago

Discussed and agreed on the comment mentioned above.

sahasomnath commented 6 years ago

image

Please make it Y instead of y. Rest Functionality is working. I'll close it after you fix the text.

sahasomnath commented 6 years ago

Also please remove "" from test name. Test name is already in CAPS so user will be bale able to understand it easily.