rssnyder / discord-stock-ticker

Add live stock & crypto prices to your discord sidebar.
https://rssnyder.github.io/discord-stock-ticker/
MIT License
294 stars 113 forks source link

Change floor activity to watch instead of streaming #181

Closed rickstaa closed 1 year ago

rickstaa commented 2 years ago

This PR uses the new UpdateWatchStatus of https://github.com/bwmarrin/discordgo/pull/1291 to set the activity to watching instead of streaming. It follows up on #180.

image

Warning This PR contains a feature of discordgo that has not yet been released please merge after https://github.com/bwmarrin/discordgo/pull/1291 has been released.

rssnyder commented 1 year ago

Sweet! Looking forward for that being merged, gonna change all my bots to use this. Please ping me when its merged.

rickstaa commented 1 year ago

Sweet! Looking forward for that being merged, gonna change all my bots to use this. Please ping me when its merged.

I will! Happy to collaborate on such an amazing project!🔥

rickstaa commented 1 year ago

@rssnyder https://github.com/bwmarrin/discordgo/pull/1291 just got merged so we can apply it to all tickers and merge this PR. 🔥

rickstaa commented 1 year ago

I can fix conflicts tomorrow.

rickstaa commented 1 year ago

I added the UpdateWatchStatus method to the other tickers and rebased the PR onto the master branch. Let's wait till a new version of https://github.com/bwmarrin/discordgo is released. We can update the go.mod file and merge it after this release. I will keep you posted.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rickstaa commented 1 year ago

@stephaniehingtgen a new discordgo version was just released so we should be good to go (see https://github.com/bwmarrin/discordgo/releases/tag/v0.27.0). 👍🏻

rssnyder commented 1 year ago

@rickstaa can you update the dependencies on your branch to use the new release? Then I will validate and merge.

rickstaa commented 1 year ago

@rickstaa can you update the dependencies on your branch to use the new release? Then I will validate and merge.

Done 👍.