search

rssnyder / discord-stock-ticker

Add live stock & crypto prices to your discord sidebar.
https://rssnyder.github.io/discord-stock-ticker/
MIT License
294 stars 113 forks source link

Add floor ticker custom activity argument #182

Closed rickstaa closed 1 year ago

rickstaa commented 1 year ago

This PR adds the activity argument to the floor ticker. It follows #181.

image

rssnyder commented 1 year ago

If you could extract just the custom activity portion of this pr we could get it tested and merged while we wait for the discordgo pr.

rickstaa commented 1 year ago

@rssnyder Done!

rickstaa commented 1 year ago

Now let me see if I understand these databases.

rickstaa commented 1 year ago

@rssnyder I think I now implemented the DB code as you requested. Please take a look 👍🏻.

rssnyder commented 1 year ago

@rssnyder I think I now implemented the DB code as you requested. Please take a look 👍🏻.

You had the right idea, but you only added it in one place. You still need to account for the new column in every place we deal with the db in floor_request.go.

Lines: 30, 169, 175

rickstaa commented 1 year ago

30

Good one! I overlooked the fact that we, of course, also need to save this new argument. 😅

rickstaa commented 1 year ago

Maybe also let's make sure the argument order is consistent in all code.

rickstaa commented 1 year ago

I put the activity after nickname everywhere now. I think the PR is now good to be merged.

rickstaa commented 1 year ago

Good one. I now know what to do for the other PRs. 💪🏻 Beautifull code and package!