search

rssnyder / discord-stock-ticker

Add live stock & crypto prices to your discord sidebar.
https://rssnyder.github.io/discord-stock-ticker/
MIT License
294 stars 113 forks source link

add price arrows #184

Closed rickstaa closed 1 year ago

rickstaa commented 1 year ago

This PR adds the arrows option to the floor ticker. This option can be used to display price direction arrows with the price. Follows up on #183.

image

rssnyder commented 1 year ago

If you could extract just the price arrows portion of this pr we could get it tested and merged while we wait for the discordgo pr.

rickstaa commented 1 year ago

If you could extract just the price arrows portion of this pr we could get it tested and merged while we wait for the discordgo pr.

I will. Do you want me to merge each new feature individually PRs or do you want me to bundle them as one big PR?

rickstaa commented 1 year ago

@rssnyder Will update this one when we merge #183.

rickstaa commented 1 year ago

@rssnyder also finished can be merged after #183.

stale[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

rickstaa commented 1 year ago

Also not stale.

rickstaa commented 1 year ago

@rssnyder can be merged after #183.

rickstaa commented 1 year ago

@rssnyder Updated to the latest master! Think we are good to go now 👍🏻.

rssnyder commented 1 year ago

@rickstaa wana rebase and ill check this out?

rickstaa commented 1 year ago

@rickstaa wana rebase and ill check this out?

Amazing! I merged instead since rebase gave me to many conflicts. Let me know what you think.

rickstaa commented 1 year ago

@rssnyder, no pressure, but I was wondering if the PR is good to go or if I still need to change something. 🫡