search

rst-tu-dortmund / teb_local_planner

An optimal trajectory planner considering distinctive topologies for mobile robots based on Timed-Elastic-Bands (ROS Package)
http://wiki.ros.org/teb_local_planner
BSD 3-Clause "New" or "Revised" License
992 stars 546 forks source link

[ros2-master] Updated parameters for ros2 master sync #280

Closed AlexKaravaev closed 3 years ago

AlexKaravaev commented 3 years ago

Resolves #220. With this params I was able to launch nav2 branch master with teb_local_planner as controller plugin

AlexKaravaev commented 3 years ago

@SteveMacenski Should I remove params, not related to controller_server from teb_params.yaml? I've added them, because the ones that are present now will not work with current nav2 master

SteveMacenski commented 3 years ago

Yeah, lets just delete all the launch files and use only the config file section for controller server. I don't want to maintain 2 sets of identical parameters for everything else. If someone's swapping out controllers, they can just copy over the parameters.

Thanks for this!

AlexKaravaev commented 3 years ago

Makes sense, I've deleted launch files and left only controller server related parameters

SteveMacenski commented 3 years ago

Thanks!

doisyg commented 3 years ago

This PR breaks compilation! I believe it is due to the complete deletion of the launch directory and the fact that it is still declared in an install step here: https://github.com/rst-tu-dortmund/teb_local_planner/blob/a805dddc4773542f89332b972c6b570b3f464177/teb_local_planner/CMakeLists.txt#L139