search

rsta2 / circle

A C++ bare metal environment for Raspberry Pi with USB (32 and 64 bit)
https://circle-rpi.readthedocs.io
GNU General Public License v3.0
1.85k stars 245 forks source link

Fix for character handling rotationfor asymetric displays #451

Closed diyelectromusic closed 5 months ago

diyelectromusic commented 5 months ago

My apologies Rene! There was a bug in the character handling for rotations which I'd missed as my displays were all square! Hopefully this sorts that out.

Sorry about that! I think that is ok now... but I don't have a wide range of displays to test it on unfortunately. Hopefully once in the branch a few others might be able to give it a go.

Many Thanks, Kevin

rsta2 commented 5 months ago

No problem, Kevin, that happens. It's good, that you have found the problem. I will test the update tomorrow and will merge it then.

Rene

diyelectromusic commented 5 months ago

Thinking about this a bit more and seeing as there are such a range of possible display sizes, I'm going to add one more configuration parameter, so hold off a while and I'll get that update to you later today.

Part of the issue is not knowing what screens/configurations were used with the original code to know why, for example, it was using double height/double width text in the first place! With smaller displays that doesn't look like it will be needed.

Thanks, Kevin

diyelectromusic commented 5 months ago

Ok, I think I'm ok with that now. See what you think.

I suspect given the wide range of displays out there, there will be things found by others in the future, but that is probably the extent of the testing I can do at my end. I don't believe I've done anything now to change whatever support or limits were in the original code.

Thanks, Kevin

rsta2 commented 5 months ago

I think, that's good. I merged it. I tested both samples successfully (character sample with 6 rows and rotation 90). I added two small other changes:

Thanks again, Rene