search

rstacruz / jquery.transit

Super-smooth CSS3 transformations and transitions for jQuery
http://ricostacruz.com/jquery.transit
7.29k stars 864 forks source link

Updating 'transitionEnd' to 'transitionend' for IE10 support #103

Closed halfmanhalfdonut closed 10 years ago

halfmanhalfdonut commented 11 years ago

IE10 Supports transitions, but is case sensitive with the transitionend event. Callbacks on that event will not fire unless it's specifically "transitionend."

Tested Browsers:

IE10 desktop (windows 8) & mobile (winphone 8) Chrome (newest) Safari 6 Mobile Safari iOS 6

lucsky commented 11 years ago

This seems to fix the same problem in Firefox (tested using FF19).

voxpelli commented 10 years ago

I think this can be merged, it's just a case of an uppercase "E" that should be lowercase as there appears to be no such thing as a "transitionEnd" event. It's defined as "transitionend" in the standard (http://dev.w3.org/csswg/css-transitions/#transitionend) and that's what at least Firefox (https://developer.mozilla.org/en-US/docs/Web/Reference/Events/transitionend) and IE (http://msdn.microsoft.com/en-us/library/ie/hh673535%28v=vs.85%29.aspx#mstransitionend) currently uses.

Removing the reference to a non-existing event will fix a lot in Firefox and IE and I see no reason to hold this fix back because of #128 and the need for a better event detection mechanism.

FossPrime commented 10 years ago

Fixes the issue in chrome 34.

rstacruz commented 10 years ago

Thanks!