search

rstacruz / jquery.transit

Super-smooth CSS3 transformations and transitions for jQuery
http://ricostacruz.com/jquery.transit
7.29k stars 864 forks source link

Fixes for broken duration #134

Closed myylow closed 11 years ago

myylow commented 11 years ago

Duration property is currently broken in two ways:

1) toMS() is called twice and the checking for a string means anything is always set back to to $.fx.speeds._default e.g. {duration: 1500} , 1500 > "1500ms" > $.fx.speeds._default

2) For code like $("#box).transition({ x:"+=100px", duration:1500 }) .transition({ x: "-=100px", duration:1500 }) the second duration reverts to default because of deleting the property.duration property the first time around. Deep cloning properties works around it.

dan-lee commented 11 years ago

Thanks for this working version! Should be pulled right away.

rstacruz commented 11 years ago

Thanks guys, these should solve a lot of issues.