rstacruz / kingraph

Plots family trees using JavaScript and Graphviz
439 stars 86 forks source link

Improve person render #4

Closed marekkalnik closed 2 years ago

marekkalnik commented 6 years ago

Add displaying date of birth and death Remove double person.name if no fullname specified

meyersbs commented 6 years ago

@rstacruz Please merge this!

AlexanderWillner commented 4 years ago

That's great. I'm using it at https://github.com/AlexanderWillner/kingraph and fixed a few bugs around this as well.

joepagan commented 4 years ago

Thanks for the heads up @AlexanderWillner I'll give yours a go soon Update: tried it & didn't work for me:

Error: mismatched tag in line 1 
... Bob Bob</table> ...
in label of node BobBob
people:
  BobBob:
    name: Bob
    fullname: Bob Bob
AlexanderWillner commented 4 years ago

@joepagan please test again, found this bug half an hour ago

joepagan commented 4 years ago

@AlexanderWillner seems to work now, looks like you've made considerable fixes and stuff, I'll likely use yours as my base going forward, thanks for your work 👍

marekkalnik commented 2 years ago

Closing to clean up my PRs as this is a dormant depository