Open liamzebedee opened 9 years ago
cc @caarlos0 @caarlos0/nprogress-rails/team — would you be cool with this?
@rstacruz yes, I think we can make this work :+1:
sure, let's get this done for 0.3 and let's try to coordinate to have nprogess-rails updated accordingly. while we're at it, anything you want to consider with the next release? maybe merging in the .scss version upstream?
and deprecating nprogress-bootstrap.css
possibly (let's have the z-index bumped up by default)?
bar
is quite a common CSS selector for a number of frameworks (Bootstrap, Ratchet, Ionic). I think it would be worth considering renaming the NProgress class.bar
to.nprogress-bar
to avoid styling conflicts. The bars (whether they be for menus or other stuff) are more significant to style in these frameworks than in this library, and probably more effort for users to rename as well.:) Liam.