search

rstacruz / nprogress

For slim progress bars like on YouTube, Medium, etc
http://ricostacruz.com/nprogress
MIT License
26.04k stars 1.81k forks source link

Rename CSS selector to avoid styling conflicts #105

Open liamzebedee opened 9 years ago

liamzebedee commented 9 years ago

bar is quite a common CSS selector for a number of frameworks (Bootstrap, Ratchet, Ionic). I think it would be worth considering renaming the NProgress class .bar to .nprogress-bar to avoid styling conflicts. The bars (whether they be for menus or other stuff) are more significant to style in these frameworks than in this library, and probably more effort for users to rename as well.

:) Liam.

rstacruz commented 9 years ago

cc @caarlos0 @caarlos0/nprogress-rails/team — would you be cool with this?

caarlos0 commented 9 years ago

@rstacruz yes, I think we can make this work :+1:

rstacruz commented 9 years ago

sure, let's get this done for 0.3 and let's try to coordinate to have nprogess-rails updated accordingly. while we're at it, anything you want to consider with the next release? maybe merging in the .scss version upstream?

rstacruz commented 9 years ago

and deprecating nprogress-bootstrap.css possibly (let's have the z-index bumped up by default)?