search

rstacruz / nprogress

For slim progress bars like on YouTube, Medium, etc
http://ricostacruz.com/nprogress
MIT License
26.09k stars 1.81k forks source link

Remove incorrect ARIA roles #183

Open kerhong opened 7 years ago

kerhong commented 7 years ago

This library currently uses invalid ARIA roles, instead use class names to select items.

List of valid roles: https://developer.mozilla.org/en-US/docs/Web/Accessibility/ARIA/ARIA_Techniques

Alternative: find some more appropriate roles for these elements.

This could be a breaking change if users are accessing or styling elements using these incorrect roles.

Fixes #180

nmackey commented 6 years ago

For anyone that finds this in the future I have forked this repo and created accessible-nprogress that adds accessibility support for this library. - https://github.com/nmackey/accessible-nprogress