rstacruz / nprogress

For slim progress bars like on YouTube, Medium, etc
http://ricostacruz.com/nprogress
MIT License
25.98k stars 1.81k forks source link

Next version update (March 2020) #218

Open rstacruz opened 4 years ago

rstacruz commented 4 years ago

WIP: While this is a work-in-progress, therelease is available under the next tag - try it out with npm install nprogress@next 😉 (draft release notes)

This updates NProgress to keep it up-to-date with 2020 standards.

Major updates

Build process updates

CI updates

Deprecations

Documentation update

CSS updates

anselal commented 4 years ago

Nicely done so far, keep up the good work. FYI, your "little" project is used widely, so you done right to update the js file to keep up with 2020 standards as well adding sass support so it can be used with new JS frameworks !!!

anselal commented 4 years ago

I created a PR for css variables

anselal commented 4 years ago

Looking good my friend. Keep up the good work !!!

vvo commented 4 years ago

Just chiming in to say: I just tried @next release and it worked perfectly. Only thin I had to change was the CSS import, to import "nprogress/css/nprogress.css"; Thanks for working on upgrading the library, it's a great library. I recently used it in a Next.js project to show the progress bar, after a delay, on Route en fetch events (https://dev.to/vvo/show-a-top-progress-bar-on-fetch-and-router-events-in-next-js-4df3)

vvo commented 4 years ago

@rstacruz For what it's worth: I did some more testing and on iOS Safari the behavior of the progress bar is different than before. When start() is called and it takes a "long" (like 3s) time before done(), the bar progress is not smooth. It jumps back and forth constantly like it's freezing.

I was able to reproduce the behavior in a very simple example (using @next):

Demo: RPReplay_Final1591869653

Same CodeSandbox but using @latest instead of @next:

Demo: RPReplay_Final1591869858

RamyRais commented 3 years ago

Hey, would you be interested to add the ability to render multiple progress bar in one page? I have this fork and would be nice to combine them.

MickL commented 2 years ago

Hey @rstacruz , adding Sass and TypeScript types is exactly what I was looking for! Seems like you finished all the work already and just the documentation is missing? Also I couldnt find the TypeScript typings so I needed to additionally install @types/nprogress :(

Btw. could you please also make the z-index, top and box-shadow a variable? I have a fixed header so I might need to customize those values.

silasabbott commented 2 years ago

Just checking up on this—@rstacruz let us know how we can help 🎉

bombillazo commented 1 year ago

Any update on this package, or has it been abandoned? Would like to know either way what the plan is for this component.