Open rstacruz opened 4 years ago
Nicely done so far, keep up the good work.
FYI, your "little" project is used widely, so you done right to update the js file to keep up with 2020 standards as well adding sass
support so it can be used with new JS frameworks !!!
I created a PR for css variables
Looking good my friend. Keep up the good work !!!
Just chiming in to say: I just tried @next
release and it worked perfectly. Only thin I had to change was the CSS import, to import "nprogress/css/nprogress.css";
Thanks for working on upgrading the library, it's a great library. I recently used it in a Next.js project to show the progress bar, after a delay, on Route en fetch events (https://dev.to/vvo/show-a-top-progress-bar-on-fetch-and-router-events-in-next-js-4df3)
@rstacruz For what it's worth: I did some more testing and on iOS Safari the behavior of the progress bar is different than before. When start() is called and it takes a "long" (like 3s) time before done(), the bar progress is not smooth. It jumps back and forth constantly like it's freezing.
I was able to reproduce the behavior in a very simple example (using @next
):
Demo:
Same CodeSandbox but using @latest
instead of @next
:
Demo:
Hey, would you be interested to add the ability to render multiple progress bar in one page? I have this fork and would be nice to combine them.
Hey @rstacruz , adding Sass and TypeScript types is exactly what I was looking for! Seems like you finished all the work already and just the documentation is missing? Also I couldnt find the TypeScript typings so I needed to additionally install @types/nprogress
:(
Btw. could you please also make the z-index
, top
and box-shadow
a variable? I have a fixed header so I might need to customize those values.
Just checking up on this—@rstacruz let us know how we can help 🎉
Any update on this package, or has it been abandoned? Would like to know either way what the plan is for this component.
This updates NProgress to keep it up-to-date with 2020 standards.
Major updates
Distirbute an ESM build. NProgress is currently a UMD distribution (ie, CommonJS and browser).
Add CSS variables support. It should be easier to change the color.
Add Sass support. Same goal as above for those who prefer Sass.
Types and documentation. This should hopefully make the experience better for TypeScript and VSCode users.
Build process updates
jest
for tests (rather than Mocha and Chai).prettier
for code formatting.microbundle
to distribute UMD, ESM, and CommonJS builds.yarn
for packaging.np
for publishing.CI updates
Deprecations
Documentation update
CSS updates