search

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.
http://ricostacruz.com/sinatra-assetpack/
MIT License
542 stars 97 forks source link

Fixes issues with quote wrapped data URIs #113

Closed bentruyman closed 11 years ago

bentruyman commented 11 years ago

Should close #112

j15e commented 11 years ago

Thanks for the PR. I though the first quote in this case should be handled by the first part of the regex which includes a conditional opening quote (["']?)?

Ideally I'd add a test case in https://github.com/rstacruz/sinatra-assetpack/blob/master/test/preproc_test.rb to cover both cases to makes sure we don't go back & forth on this issue.

bentruyman commented 11 years ago

Thanks for the quick response! The updated test in the PR should test 3 cases: unquoted, single-quoted and double-quoted.

j15e commented 11 years ago

Oh sorry, didn't see the updated test because Github isn't showing it eh (don't know why)

3 additions, 3 deletions not shown

j15e commented 11 years ago

Released in 0.2.6