Correctly handle empty list of engines in Tilt.mappings

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.

http://ricostacruz.com/sinatra-assetpack/

MIT License

542 stars 97 forks source link

Correctly handle empty list of engines in Tilt.mappings #125

Closed niallsmart closed 11 years ago

niallsmart commented 11 years ago

The implementation of AssetPack.tilt_formats currently assumes there is always at least one engine registered for a given Tilt format, but that is not always the case (related: https://github.com/rtomayko/tilt/pull/206)

This patch skips over formats that don't have an engine instead of calling methods on nil.

j15e commented 11 years ago

Thanks, I'll merge but add a reminder to remove this when tilt PR get merged, sounds good?

niallsmart commented 11 years ago

Sounds good – this scenario shouldn't happen once the bug in Tilt is fixed.

MaxPleaner commented 8 years ago

submitted new pull request to address this as Tilt.mappings is nonexistent in current sinatra https://github.com/rstacruz/sinatra-assetpack/pull/201