search

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.
http://ricostacruz.com/sinatra-assetpack/
MIT License
542 stars 97 forks source link

Account for suburi in img helper #144

Closed mattaddy closed 10 years ago

mattaddy commented 10 years ago

Currently, the img helper does not prepend the suburi to the generated image tag output (see #136). For example,

!= img '/images/foo.png'

will output

<img src='/images/foo.<cache-buster>.png' />

This is a problem when the app is deployed to a suburi in production. My thought is the img helper should behave similarly to the js and css helper by prepending the suburi to the generated html output.

mattaddy commented 10 years ago

Sorry, I'm not sure why travis-ci is failing to build. Tests are passing on my machine running ruby 2.0.0 patch 250.

j15e commented 10 years ago

Seems legit, build is failing because missing rbx binary, not a real issue, I'll merge.