search

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.
http://ricostacruz.com/sinatra-assetpack/
MIT License
542 stars 97 forks source link

data uri not parsing corrected ? #151

Closed cpitani closed 10 years ago

cpitani commented 10 years ago

There are 2 issues for me .

  1. the sinatra-assetpack as downloaded from rubygems didnt have the latest source for lib/sinatra/assetpack/css.rb in the github. I didnt get the fix for data uri with it.
  2. my style sheet which has data uri is still not parsing correctly. in the format url("data:image/png;...");

I fixed the regex in my source from str.gsub(/url((["']?)(?!data:)(.?)(["']?))/) to str.gsub(/url((["']?)(!data:)(.?)(["']?))/)

removed ? before !data: and its working properly. Please see if you can fix it in the source.

j15e commented 10 years ago

Check out how pull requests works, you could just send me the patch that way! Thanks for reporting.

cpitani commented 10 years ago

hi, i made the change and sent pull request. Please check.

On Fri, Jan 17, 2014 at 9:48 PM, Jean-Philippe Doyle < notifications@github.com> wrote:

Check out how pull requestshttps://help.github.com/articles/using-pull-requestsworks, you could just send me the patch that way! Thanks for reporting.

— Reply to this email directly or view it on GitHubhttps://github.com/rstacruz/sinatra-assetpack/issues/151#issuecomment-32675375 .

j15e commented 10 years ago

Thanks I'll review & merge soon