search

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.
http://ricostacruz.com/sinatra-assetpack/
MIT License
542 stars 97 forks source link

added compress_environments setting #180

Closed stillinbeta closed 9 years ago

stillinbeta commented 9 years ago

Allows you to use compression (concatenation) on static assets in RACK_ENVs other than production (e.g. staging)

I didn't see the docs in the repository, so I didn't update them. If you point me to where they're stored I can send a PR for that too :)

j15e commented 9 years ago

Not a bad idea, but I do not think this is how we should manage environment specific settings.

We should add a setting attrib :compress which would default to true for production, but could be overwritten easily according to your environment preference.

Otherwise, in the way you suggest to fix this, we could end up having a ****_environments for every setting and things would get messy pretty fast.