search

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.
http://ricostacruz.com/sinatra-assetpack/
MIT License
541 stars 97 forks source link

Adding cache control headers to packed assets, too. Make custom cache control possible. #43

Closed niko closed 11 years ago

niko commented 12 years ago

Closes #42 and #3. Includes missing testcases, bugfix and tests, new feature and tests, documentation.

rstacruz commented 12 years ago

Great! Looks pretty solid on first glance... I'll dissect it and merge it in soon.

niko commented 12 years ago

Cool. Looking forward. :)

niko commented 12 years ago

Rico, sry for bugging you… any news here?

niko commented 12 years ago

I accidently pushed the other change in my master branch, sry. I get somewhat confused with the two pull requests and my own other changes. If I remember right "fixing" this by removing the commit by force-pushing will break the pull request. Not sure what I should do now.

kzk commented 11 years ago

@rstacruz @niko any progress on merging this? sad to see optimized assets without cache-control header :(

phillbaker commented 11 years ago

+1 on this PR. I have another PR waiting though, for just as long. Looks like @rstacruz is more responsive on Twitter, same handle. Maybe someone can ping him there?

kzk commented 11 years ago

@phillbaker @rstacruz just pinged on Twitter > https://twitter.com/kzk_mover/status/263428496137809920

j15e commented 11 years ago

Will look into merge for next release, would be great if you could rebase it on master

niko commented 11 years ago

Just pushed the rebased version. Seems you already merged the commit yourself. Thanks a lot for continuing the work on asset-pack. Highly appreciated!

j15e commented 11 years ago

Seems like you have done a merge, could you rebase on current master and push force your patch so only the patch commits be included here?