search

rstacruz / sinatra-assetpack

Package your assets transparently in Sinatra.
http://ricostacruz.com/sinatra-assetpack/
MIT License
541 stars 97 forks source link

Less support #69

Closed phillbaker closed 11 years ago

phillbaker commented 11 years ago

This is a rebase of the earlier pull request (#49) of the same name. It does not fix the issues mentioned in the request. That will follow in a separate request.

Running bundle exec rake to run the tests results in two failing tests, but both of these test also fail on master.

j15e commented 11 years ago

Hi, thanks for updating your PR as requested, it could now be merge as is, but could you squash this into one commit? Seems like a lots of commits for a few files changes, I like to keep my history clean :smile:

Also, please try to rebase instead of merging the remote branch, this creates a useless merge

PS you can push force your patch branch instead of closing/re-opening a new PR, it's faster

phillbaker commented 11 years ago

Fair 'nough. Squashed + rebased. Thanks!

j15e commented 11 years ago

Awesome, thanks for you patience