enable dynamic asset caching as an option to speed up development reques...

[bporterfield]

...ts - only compile dynamic assets after first request if the file has been modified.

In development, dynamic asset caching for large packages was slowing down page requests significantly. This flag enables caching for compiled assets until the file has been changed.

[j15e]

Hi, thanks for the PR, nice work, I have 2 comments :

• The 2nd test does not really test the behavior of the new feature, you should check whether the file is really processed only once, checking ex. wether the file is read from source or if the preprocessor is called.
• I think you could rename your setting name with something simpler like cache_dynamic_assets

[bporterfield]

Thanks for feedback. Renamed setting to simpler name and updated test!

[j15e]

I think instead of overwriting the File.send method manually you could use a stub and/or expect call from mocha as in this test :

https://github.com/rstacruz/sinatra-assetpack/blob/master/test/cache_test.rb#L23

http://gofreerange.com/mocha/docs/

[bporterfield]

Never used stubs but made an attempt. Thanks for feedback!

[j15e]

I update the test before merging I think you might like to have a look! Your test with raises was testing that something would not happen, I prefer to test that call happen but a limited times :

  test "served from cache" do
    app.assets.cache_dynamic_assets = true
    Sinatra::AssetPack::Css.stubs(:preproc).times(1)
    get '/css/screen.css'
    get '/css/screen.css'
    get '/css/screen.css'
    assert last_response.status == 200
  end

https://github.com/rstacruz/sinatra-assetpack/blob/master/test/cache_dynamic_assets_test.rb

[bporterfield]

Interesting! I was under the mistaken impression that times(x) would revert back to original method signature after x times. This makes a lot more sense. Thanks for the merge!