rstaib / jquery-bootgrid

Nice, sleek and intuitive. A grid control especially designed for bootstrap.
http://www.jquery-bootgrid.com
MIT License
974 stars 363 forks source link

Icons do not appear #249

Open skywish opened 8 years ago

skywish commented 8 years ago

Hi author, I download the source code from http://www.jquery-bootgrid.com/GettingStarted#download and I notice that the icons do not appear in demo! I read the codes again and again, finally I know that you forgot to add font-awesome.css.

blakemcbride commented 8 years ago

I think what is needed is for the setup docs to indicate that font-awesome should be loaded. Without documenting this need, every person who uses bootgrid runs into this problem. For those less familiar with this technology, missing docs like this can cost a person hours and days of lost time.

adams141 commented 8 years ago

I like font awesome, but didn't want to add it just for these icons, so I changed jquery.bootgrid.fa.js to use the bootstrap icons instead:

icon: "icon glyphicon", iconColumns: "glyphicon-list", iconDown: "glyphicon-triangle-bottom", iconRefresh: "glyphicon-repeat", iconSearch: "glyphicon-search", iconUp: "glyphicon-triangle-top"

jgodstime commented 6 years ago

adams141 please where do we add this line of code and can you please show us how to use it. i will be very gratefull, am having issues using it. Thanks

adams141 commented 6 years ago

jgodstime , there really isn't much code in jquery.bootgrid.fa.js besides what I posted, though the formatting is off. Just replace the css classes with:

`icon: "icon glyphicon",

iconColumns: "glyphicon-list",

iconDown: "glyphicon-triangle-bottom",

iconRefresh: "glyphicon-repeat",

iconSearch: "glyphicon-search",

iconUp: "glyphicon-triangle-top"`

MenaceSan commented 6 years ago

The solution to move from fontawesome back to bootstrap icons doesnt work for bootstrap 4 since the glyphicons are gone. Anyone wanting to target bootstrap 4 should ust use the fontawesome icons. This is of course made extremety confusing by the fact jquery-bootgrid 1.3.1. changed the defaults to use bootstrap 3 glyphicon as suggested above. There is a solution provided in bootgrid . Just add as well,. IT reverts back to fontawesome.