rsteckline / rancid-tomatillos

https://rancid-tomatillos-dusky.vercel.app

0 stars 1 forks source link

Feature/setup apis #22

Closed ericahagle closed 11 months ago

ericahagle commented 11 months ago

Description

Adds fetch for all movie data
- Also added a check in Movies to display "Loading..." if the movies haven't loaded in yet, to make the UX nicer
Removes unnecessary imports for mock-data and Card in App.js
- I left the mock-data.js file in the repo for now, in case we get crazy later and decide that we want to figure out how to do some unit tests
Also includes some minor formatting tweaks to the code

Notes

Basic error handling is in, but we can work on handling it more elegantly in a subsequent PR for this ticket: https://github.com/rjsturing/rancid-tomatillos/issues/13

Checklist

[x] My PR has an appropriately descriptive and concise title.
[x] My code follows the Turing Style Guides and best practices.
[x] I ran the code locally and verified that there are no visible errors.
[x] feat: My PR clearly describes what feature I'm adding and any changes needed to make it work.
[x] refactor: My PR clearly describes what code I'm refactoring and why.