search

rstropek-teaching / real-time-game-quiz-4ahif-Kueblboeck

real-time-game-quiz-4ahif-Kueblboeck created by GitHub Classroom
0 stars 0 forks source link

Don't check in node_modules #2

Open rstropek opened 6 years ago

rstropek commented 6 years ago

Hi @Mkublbock

I am currently looking at your code because of the issue you created. I recognized that you checked in the node_modules folder. Don't do that. It is unnecessarily large and other developers who would like to contribute will run into troubles.

I recommend creating a .gitignore file and adding node_modules to it.

Greetings, Rainer Stropek.

rstropek commented 6 years ago

Also note that you use browser-sync in your NPM scripts. However, browser-sync is not included in your references in package.json. Don't forget to run npm install browser-sync --save-dev.

Greetings, Rainer Stropek.

rstropek commented 6 years ago

Hmm, after a closer look I think that browser-sync is no longer needed, is it? If not, please delete the related script in package.json.

Greetings, Rainer Stropek.

Mkublbock commented 6 years ago

Browser-sync isn´t needed anymore that´s right. Still I am facing the issue of exports not defines in my game.js:2. I guess it has something to do with game.js running in the browser because in server.js there´s also an 'exports' but it doesn´t run on the browser