rstrouse / ESPSomfy-RTS-HA

Control your somfy shades in Home Assistant
The Unlicense
125 stars 9 forks source link

Awnings Up/Down not working on HA (inverted?) #51

Closed Noltari closed 4 months ago

Noltari commented 6 months ago

Open and Close seems to be inverted in Home Assistant, but it works correctly from the ESPSomfy-RTS website.

Awnings are open on ESPSomfy-RTS: image

And Home Assistant displays it correctly: image However, if I try to press Close on the Awnings Group, it does nothing.

But if I use the slider, it works correctly: image image

But then, the same happens again if I try to open them: image It's like the bug only affects the Open/Close buttons and not the slider...

Noltari commented 6 months ago

So I just did more tests and I can confirm that Open/Close is inverted for the awnings group but only on Home Assistant, since ESPSomfy-RTS works perfectly.

If I start with the awnings on an intermediate position and press Open: image

Then the awnings close instead of opening: image

rstrouse commented 6 months ago

HA is a menace when it comes to awnings. Do the awnings operate properly as individuals?

Noltari commented 6 months ago

HA is a menace when it comes to awnings.

Yeah...

Do the awnings operate properly as individuals?

Yes, they operate perfectly fine as individuals.

rstrouse commented 5 months ago

I’ll take a look at the types assigned to the groups in HA. Because of the way awnings are implemented on the card they operate incorrectly. I will look at adding the work around s that I had to do for the single cover entity to the cover group entity based on whether an awning type is assigned.

Noltari commented 5 months ago

I’ll take a look at the types assigned to the groups in HA. Because of the way awnings are implemented on the card they operate incorrectly. I will look at adding the work around s that I had to do for the single cover entity to the cover group entity based on whether an awning type is assigned.

Thanks!

rstrouse commented 5 months ago

Out of curiosity did you change the entity using the Show As dropdown to an awning or did HA come up with that entity type all by itself?

Noltari commented 5 months ago

Out of curiosity did you change the entity using the Show As dropdown to an awning or did HA come up with that entity type all by itself?

@rstrouse honestly I don't remember, but I think I changed it manually...

rstrouse commented 5 months ago

Change it back to Shade and see if it reacts appropriately. The whole thing with awnings are goofball in HA. When I get a chance I will detect the awning setting and flip everything around.

Noltari commented 5 months ago

Change it back to Shade and see if it reacts appropriately. The whole thing with awnings are goofball in HA. When I get a chance I will detect the awning setting and flip everything around.

I changed it back to Shade but it's still the same: image

As you can see, only going up is enabled, and the awnings group is already closed, so it does nothing...

rstrouse commented 5 months ago

Well that is unfortunate. They really did stub their toe on the awning entity. It looks like I will need to apply all the gymnastics that were required for an individual awning to the group. Kinda silly given there would be no way to mix and match awnings and shades in a single group and get the desired results.

rstrouse commented 4 months ago

HA really made this hard with the goofiness of the awning device class. I will have a workaround operating in v2.4.3 of the plugin soon that preforms gymnastics on group entities. Essentially when it encounters a group with mismatched entity positions it will translate the commands differently. It is all just a bit silly.

rstrouse commented 4 months ago

Accidentally closed this when I posted a fix. I will release it this weekend.

Noltari commented 4 months ago

Thanks @rstrouse, it's working now with https://github.com/rstrouse/ESPSomfy-RTS-HA/releases/tag/v2.4.3

rstrouse commented 4 months ago

Awesome. I am going to close this out for now.