rstrouse / nodejs-poolController-dashPanel

A dashboard panel for tagyoureit/nodejs-poolController
33 stars 20 forks source link

Dockerfile fix #46

Closed putnam closed 2 years ago

putnam commented 2 years ago

The python package in the Dockerfile is no longer included in alpine; it has been deprecated in favor of explicit versioning. python3 works for this case. Without this fix, the sample Docker image will not build.

rstrouse commented 2 years ago

So what needs to change in Dockerfile? Change python to python3?

FROM node:lts-alpine as build
RUN apk add --no-cache make gcc g++ python linux-headers udev tzdata
WORKDIR /app
COPY package*.json ./
RUN npm ci
COPY . .
RUN npm run build
RUN npm ci --production

FROM node:lts-alpine
RUN apk add git
RUN mkdir /app && chown node:node /app && mkdir /app/data && chown node:node /app/data
WORKDIR /app
COPY --chown=node:node --from=build /app .
USER node
ENV NODE_ENV=production
ENTRYPOINT ["node", "dist/app.js"]
putnam commented 2 years ago

Yep just change that "python" in the second line to "python3"

On Fri, Dec 17, 2021 at 8:59 PM rstrouse @.***> wrote:

So what needs to change in Dockerfile? Change python to python3?

FROM node:lts-alpine as build RUN apk add --no-cache make gcc g++ python linux-headers udev tzdata WORKDIR /app COPY package*.json ./ RUN npm ci COPY . . RUN npm run build RUN npm ci --production

FROM node:lts-alpine RUN apk add git RUN mkdir /app && chown node:node /app && mkdir /app/data && chown node:node /app/data WORKDIR /app COPY --chown=node:node --from=build /app . USER node ENV NODE_ENV=production ENTRYPOINT ["node", "dist/app.js"]

— Reply to this email directly, view it on GitHub https://github.com/rstrouse/nodejs-poolController-dashPanel/issues/46#issuecomment-997131438, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAASBTYPO266DRYADXXZ2FTURP2IHANCNFSM5KIJCQFA . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.

You are receiving this because you authored the thread.Message ID: @.***>

putnam commented 2 years ago

Fixed