Missing mmsegmentation and mmcv in requirements

rstrudel / segmenter

[ICCV2021] Official PyTorch implementation of Segmenter: Transformer for Semantic Segmentation

MIT License

846 stars 176 forks source link

Missing mmsegmentation and mmcv in requirements #5

Closed theevann closed 3 years ago

theevann commented 3 years ago

Just so you know, if you wish to update it :)

theevann commented 3 years ago

Never mind, I see from your Readme that you probably purposely didn't put it.

rstrudel commented 3 years ago

Hi @theevann ,

Thanks for your comment. Yes it's not so obvious as mmcv comes shipped with pytorch and cuda, which is hardware dependent. I chose to suggest to install torch first and let the user pick something compatible with its hardware before installing mmcv and mmsegmentation.

Robin

rstrudel commented 3 years ago

@theevann I added mmcv and mmsegmentation in the requirements, seems to be working without problems and simplifies the setup, thanks for the suggestion !