search

rstudio-conf-2020 / time-series-forecasting

Creative Commons Attribution Share Alike 4.0 International
222 stars 131 forks source link

Not compiling #6

Closed robjhyndman closed 4 years ago

robjhyndman commented 4 years ago

Using CRAN version of tsibble and latest github versions of fable, feasts, fabletools. 

Quitting from lines 196-205 (6-fable.Rmd) 
Error: No common type for `..1` <interval> and `..2` <double>.
<error/vctrs_error_incompatible_type>
No common type for `..1` <interval> and `..2` <double>.
mitchelloharawild commented 4 years ago

I cannot reproduce this. Can you provide your sessionInfo()?

R version 3.6.1 (2019-07-05)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.3 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.7.1
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.7.1

locale:
 [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8    
 [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8   
 [7] LC_PAPER=en_AU.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods  
[7] base     

other attached packages:
 [1] fable_0.1.1.9000      feasts_0.1.1.9000    
 [3] fabletools_0.1.1.9000 tsibbledata_0.1.0    
 [5] tsibble_0.8.5         lubridate_1.7.4      
 [7] fpp3_0.1              forcats_0.4.0        
 [9] stringr_1.4.0         dplyr_0.8.3          
[11] purrr_0.3.3           readr_1.3.1          
[13] tidyr_1.0.0           tibble_2.1.3         
[15] ggplot2_3.2.1         tidyverse_1.3.0      

loaded via a namespace (and not attached):
 [1] tseries_0.10-47   expsmooth_2.3     httr_1.4.1       
 [4] jsonlite_1.6      modelr_0.1.5      assertthat_0.2.1 
 [7] TTR_0.23-5        fma_2.3           cellranger_1.1.0 
[10] yaml_2.2.0        pillar_1.4.3      backports_1.1.5  
[13] lattice_0.20-38   glue_1.3.1        quadprog_1.5-8   
[16] digest_0.6.23     rvest_0.3.5       colorspace_1.4-1 
[19] htmltools_0.4.0   timeDate_3043.102 pkgconfig_2.0.3  
[22] broom_0.5.2       haven_2.2.0       scales_1.1.0     
[25] binb_0.0.5        farver_2.0.2      generics_0.0.2   
[28] ellipsis_0.3.0    withr_2.1.2       urca_1.3-0       
[31] nnet_7.3-12       lazyeval_0.2.2    cli_2.0.1        
[34] quantmod_0.4-15   magrittr_1.5      crayon_1.3.4     
[37] readxl_1.3.1      forecast_8.10     evaluate_0.14    
[40] fs_1.3.1          fansi_0.4.1       nlme_3.1-142     
[43] anytime_0.3.6     xts_0.11-2        xml2_1.2.2       
[46] tools_3.6.1       hms_0.5.2         fpp2_2.3         
[49] lifecycle_0.1.0   munsell_0.5.0     reprex_0.3.0     
[52] packrat_0.5.0     compiler_3.6.1    tinytex_0.17     
[55] rlang_0.4.2       grid_3.6.1        rstudioapi_0.10  
[58] labeling_0.3      rmarkdown_1.18    codetools_0.2-16 
[61] gtable_0.3.0      fracdiff_1.4-2    curl_4.3         
[64] DBI_1.0.0         R6_2.4.1          zoo_1.8-6        
[67] knitr_1.26        utf8_1.1.4        zeallot_0.1.0    
[70] stringi_1.4.4     parallel_3.6.1    Rcpp_1.0.3       
[73] vctrs_0.2.1       dbplyr_1.4.2      tidyselect_0.2.5 
[76] xfun_0.11         lmtest_0.9-37
robjhyndman commented 4 years ago 
> sessionInfo()
R version 3.6.2 (2019-12-12)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 19.10

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.8.0
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.8.0

locale:
 [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C               LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8    
 [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8    LC_PAPER=en_AU.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C             LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods   base     

other attached packages:
 [1] fable_0.1.1.9000       feasts_0.1.1.9000      fabletools_0.1.1.9000  tsibbledata_0.1.0.9000
 [5] tsibble_0.8.5          lubridate_1.7.4        fpp3_0.1               forcats_0.4.0         
 [9] stringr_1.4.0          dplyr_0.8.3            purrr_0.3.3            readr_1.3.1           
[13] tidyr_1.0.0            tibble_2.1.3           ggplot2_3.3.0.9000     tidyverse_1.3.0       

loaded via a namespace (and not attached):
 [1] nlme_3.1-143         crancache_0.0.0.9001 fs_1.3.1             xts_0.11-2           bit64_0.9-7         
 [6] httr_1.4.1           rprojroot_1.3-2      tools_3.6.2          backports_1.1.5      R6_2.4.1            
[11] DBI_1.1.0            colorspace_1.4-1     nnet_7.3-12          withr_2.1.2          tidyselect_0.2.5    
[16] processx_3.4.1       bit_1.1-14           curl_4.3             compiler_3.6.2       cli_2.0.1           
[21] rvest_0.3.5          fma_2.4              xml2_1.2.2           desc_1.2.0           tseries_0.10-47     
[26] scales_1.1.0         lmtest_0.9-37        fracdiff_1.5-0       cranlike_1.0.2       quadprog_1.5-8      
[31] expsmooth_2.4        callr_3.4.0          rappdirs_0.3.1       digest_0.6.23        rmarkdown_2.0.5     
[36] htmltools_0.4.0      pkgconfig_2.0.3      dbplyr_1.4.2         rlang_0.4.2.9000     readxl_1.3.1        
[41] TTR_0.23-6           rstudioapi_0.10      quantmod_0.4-15      RSQLite_2.2.0        generics_0.0.2      
[46] zoo_1.8-7            jsonlite_1.6         magrittr_1.5         binb_0.0.5           Rcpp_1.0.3          
[51] munsell_0.5.0        fansi_0.4.1          lifecycle_0.1.0      yaml_2.2.0           stringi_1.4.5       
[56] forecast_8.10.0.9000 debugme_1.1.0        grid_3.6.2           blob_1.2.0           parallel_3.6.2      
[61] crayon_1.3.4         lattice_0.20-38      haven_2.2.0          hms_0.5.3            zeallot_0.1.0       
[66] knitr_1.26.2         parsedate_1.2.0      anytime_0.3.6        ps_1.3.0             pillar_1.4.3        
[71] fpp2_2.3             reprex_0.3.0         urca_1.3-0           glue_1.3.1           evaluate_0.14       
[76] remotes_2.1.0        modelr_0.1.5         vctrs_0.2.1          cellranger_1.1.0     gtable_0.3.0        
[81] rematch2_2.1.0       assertthat_0.2.1     xfun_0.11            broom_0.5.3          timeDate_3043.102   
[86] memoise_1.1.0
mitchelloharawild commented 4 years ago

I've updated all my packages to latest CRAN releases, and installed dev packages as you have listed above and cannot reproduce this issue. I do notice some extraneous packages listed in your sessionInfo(), can you get a clean session report by running rmarkdown::render("materials/6-fable.Rmd") after restarting the R session?

Also the lines reported seem pretty innocuous for the vctrs issue reported. https://github.com/rstudio-conf-2020/time-series-forecasting/blob/a82a0df67d5a9da118dec27dbe35d57f16322dc0/materials/6-fable.Rmd#L195-L205

Are you able to run that code interactively?

> sessionInfo()
R version 3.6.1 (2019-07-05)
Platform: x86_64-pc-linux-gnu (64-bit)
Running under: Ubuntu 18.04.3 LTS

Matrix products: default
BLAS:   /usr/lib/x86_64-linux-gnu/blas/libblas.so.3.7.1
LAPACK: /usr/lib/x86_64-linux-gnu/lapack/liblapack.so.3.7.1

locale:
 [1] LC_CTYPE=en_AU.UTF-8       LC_NUMERIC=C              
 [3] LC_TIME=en_AU.UTF-8        LC_COLLATE=en_AU.UTF-8    
 [5] LC_MONETARY=en_AU.UTF-8    LC_MESSAGES=en_AU.UTF-8   
 [7] LC_PAPER=en_AU.UTF-8       LC_NAME=C                 
 [9] LC_ADDRESS=C               LC_TELEPHONE=C            
[11] LC_MEASUREMENT=en_AU.UTF-8 LC_IDENTIFICATION=C       

attached base packages:
[1] stats     graphics  grDevices utils     datasets  methods  
[7] base     

other attached packages:
 [1] fable_0.1.1.9000      feasts_0.1.1.9000    
 [3] fabletools_0.1.1.9000 tsibbledata_0.1.0    
 [5] tsibble_0.8.5         lubridate_1.7.4      
 [7] fpp3_0.1              forcats_0.4.0        
 [9] stringr_1.4.0         dplyr_0.8.3          
[11] purrr_0.3.3           readr_1.3.1          
[13] tidyr_1.0.0           tibble_2.1.3         
[15] ggplot2_3.3.0.9000    tidyverse_1.3.0      

loaded via a namespace (and not attached):
 [1] tseries_0.10-47      expsmooth_2.3       
 [3] httr_1.4.1           jsonlite_1.6        
 [5] modelr_0.1.5         assertthat_0.2.1    
 [7] TTR_0.23-6           fma_2.3             
 [9] cellranger_1.1.0     yaml_2.2.0          
[11] pillar_1.4.3         backports_1.1.5     
[13] lattice_0.20-38      glue_1.3.1          
[15] quadprog_1.5-8       digest_0.6.23       
[17] rvest_0.3.5          colorspace_1.4-1    
[19] htmltools_0.4.0      timeDate_3043.102   
[21] pkgconfig_2.0.3      broom_0.5.3         
[23] haven_2.2.0          scales_1.1.0        
[25] binb_0.0.5           farver_2.0.2        
[27] generics_0.0.2       ellipsis_0.3.0      
[29] withr_2.1.2          urca_1.3-0          
[31] nnet_7.3-12          cli_2.0.1           
[33] quantmod_0.4-15      magrittr_1.5        
[35] crayon_1.3.4         readxl_1.3.1        
[37] forecast_8.10.0.9000 evaluate_0.14       
[39] fs_1.3.1             fansi_0.4.1         
[41] nlme_3.1-142         anytime_0.3.6       
[43] xts_0.11-2           xml2_1.2.2          
[45] tools_3.6.1          hms_0.5.3           
[47] fpp2_2.3             lifecycle_0.1.0     
[49] munsell_0.5.0        reprex_0.3.0        
[51] packrat_0.5.0        compiler_3.6.1      
[53] tinytex_0.18         rlang_0.4.2.9000    
[55] grid_3.6.1           rstudioapi_0.10     
[57] labeling_0.3         rmarkdown_2.0       
[59] codetools_0.2-16     gtable_0.3.0        
[61] fracdiff_1.5-0       curl_4.3            
[63] DBI_1.1.0            R6_2.4.1            
[65] zoo_1.8-7            knitr_1.26          
[67] utf8_1.1.4           zeallot_0.1.0       
[69] stringi_1.4.5        parallel_3.6.1      
[71] Rcpp_1.0.3           vctrs_0.2.1         
[73] dbplyr_1.4.2         tidyselect_0.2.5    
[75] xfun_0.11            lmtest_0.9-37
robjhyndman commented 4 years ago

The same problems running interactively and in a clean session. It seems to be a problem between tsibbledata and tsibble. I'll keep investigating.

robjhyndman commented 4 years ago

Maybe caused by https://github.com/tidyverts/tsibbledata/commit/5913584c8c9815c0fd270c3fd33ec2f16847fefe

robjhyndman commented 4 years ago

Yes, winding back to the previous github commit fixed the issue.

mitchelloharawild commented 4 years ago

That makes sense, I've added the proper tsibble version dep on tsibbledata now (https://github.com/tidyverts/tsibbledata/commit/25e8f53669988942bef84e4a77162fbe306b5dd5)