search

rstudio-education / stat545

A :book: on data wrangling, exploration, & analysis with R - created by Jenny Bryan, made with bookdown
https://stat545.com
Other
148 stars 92 forks source link

Fix TOC numbering for Part II (version control and R Markdown)? #48

Closed apreshill closed 5 years ago

apreshill commented 5 years ago

Hey @jennybc,

I wonder if you meant to unnumber those chapters in Part II? I think it makes sense to have the "Meta thoughts" chapter unnumbered but the other ones look a bit out of place.

Also a side note on the CSS here: it automatically will grab the first unnumbered chapter within each part and transforms the text to upper-case, so that is why "META THOUGHTS" looks like that. I think it works well for when you want a part to have an overview (as you can see in "All the Graph Things"), and thought we might want to add some in for consistency to earlier parts too at some point to frame out individual parts (since it is annoying to me that bookdown won't allow you to link to the parts themselves).

Screen Shot 2019-09-19 at 2 14 10 PM

If you agree aesthetically with numbering, I can offer a PR to fix.

jennybc commented 5 years ago

I wonder if you meant to unnumber those chapters in section II? I think it makes sense to have the "Meta thoughts" section unnumbered but the other ones look a bit out of place.

It was intentional. But not a deeply held opinion. And after I initially created these chapters, I also reordered them, which made things weirder.

Just for vocabulary's sake, I think when you say section ... you mean "part"? In bookdown lingo. And yeah it is frustrating that you can't link to a part or easily give it a bit of front matter.

jennybc commented 5 years ago

So, yes, PR welcome.

jennybc commented 5 years ago

META THOUGHTS can probably become OVERVIEW

apreshill commented 5 years ago

Yes, I edited to parts for clarity above, and will do a PR.

jennybc commented 5 years ago

Closed in 89ad10220466113d4af4a239b8ebbc144108874d