Bugfix: Correctly sort re-ordered columns

rstudio / DT

R Interface to the jQuery Plug-in DataTables

https://rstudio.github.io/DT/

Other

587 stars 184 forks source link

Bugfix: Correctly sort re-ordered columns #1096

Closed ashbaldry closed 7 months ago

ashbaldry commented 7 months ago

The re-ordered column order isn't sent server-side, so have added the column names to the DT options. This gets passed into the server-side parameters in columns$[[col_id]]$name (adding it to data instead caused errors)

This PR should resolve #534 , #921 and #1069

CLAassistant commented 7 months ago

All committers have signed the CLA.

yihui commented 7 months ago

It turns out that sorting is easier to fix, and it took me quite a while to figure out how to fix searching, thanks to your guidance.

I think this PR is ready to go now.

ashbaldry commented 7 months ago

Glad I could help! Didn't realise that the search was also not working when re-ordered