Closed mikmart closed 5 months ago
Happy to help. And thank you for blogging about this! You were right, this was a fun project.
I added the NEWS item and also:
NA
strings count for null
in client-side processing.null
evaluation rules in a unit test.Thanks a lot for the work @mikmart , @yihui
Just a question that i cannot find an answer to, i used the code above to test, works like a charm, but for the factor column (c), when i try to add a condition, it is giving me a textbox instead of dropdown of choices, is this how it is supposed to be? or should i add another option somewhere to let me choose from fixed values (since it is a factor),
Thanks in advance,
Thanks for trying it out @AhmedKhaled945! What you're seeing is actually a documented feature of the SearchBuilder extension in server-side processing mode (emphasis added):
There are two caveats that SearchBuilder's server-side integration carries. The first is that anywhere select elements would normally be used on the client-side, input elements are used instead. This reduces strain on the server significantly, drastically improving performance.
I'm not aware of any straightforward way to change this behaviour.
Ok got it, thanks a lot @mikmart
Fixes #963.
This PR adds support for SearchBuilder in server-side processing. I did not add support for the
moment
orluxon
column types as I'm not sure how they map to R types. Thearray
column type is not supported either.Notably datetime columns are treated as character data. This seems to be a limitation with the SearchBuilder extension.
I was not sure how to map the
null
or empty conditions into R. The approach I chose was to map them to missing values, and, for character columns, also to empty strings.I added some unit tests to confirm that the main components in the processing work as intended, but did not attempt to get thorough coverage on all cases. In addition to the unit tests, I used this app for some further manual testing: